feat(cli): allow arbitrary project structure for LibDeploy and system types#309
Closed
dk1a wants to merge 2 commits into
Closed
feat(cli): allow arbitrary project structure for LibDeploy and system types#309dk1a wants to merge 2 commits into
dk1a wants to merge 2 commits into
Conversation
This was referenced Jan 2, 2023
dk1a
force-pushed
the
dk1a/subdirs
branch
2 times, most recently
from
5910b35 to
8df2b31
Compare
Contributor
Author
|
I'll be testing it for a while longer, but I removed dependencies, it seems to work, and should be ready for a general review |
dk1a
force-pushed
the
dk1a/subdirs
branch
3 times, most recently
from
63acccf to
110373f
Compare
Contributor
Author
|
added support for initializer libs, another emojimon branch to test that it works with current projects (gotta link it locally). Basically the only things that would change are local LibDeploy+Deploy |
Contributor
Author
|
Closing for now, parts of it will be in a separate PR, the rest will PR to v2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#311 would help with highlighting for Vm, but isn't required.
Removes the need for systems to be in
src/systemsor components insrc/components.srcis taken from foundry.toml, names are taken from deploy.json, and then relative paths are built accordingly.The new requirement is to just not have 2 identically named files (in different folders) for 1 system/component.
This should work fine with most (probably all) existing project structures, but also allows changing them.
The main things that changed are:
generateLibDeployand its dependents (like codegen-libdeploy, deploy-contracts, deploy, test)generateSystemTypesand its dependents (types, system-types, deploy-contracts, deploy)handlerandgenerateAndDeploygenerate LibDeploy intestdir from forgeConfig (which by default istest, notsrc/test. Not really a breaking change, but a change. Is it bad?)deploycopiesDeploy.solscript totestdir along with LibDeploy.TODO for a followup:
hsr.ts: tracking usessystemfolder only, so only works with the old structure; default root should come from getForgeConfig instead of a hardcoded argumenttrace.ts: hardcoded/src/components/etc